Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Catalog] Unable to open the product from sidebar's Compare Products block #27451

Merged
merged 10 commits into from
Jun 13, 2020
Merged

[Catalog] Unable to open the product from sidebar's Compare Products block #27451

merged 10 commits into from
Jun 13, 2020

Conversation

eduard13
Copy link
Contributor

@eduard13 eduard13 commented Mar 26, 2020 •
edited by sdzhepa
Loading

Description (*)

This PR fixes the issue related to opening a product from the sidebar compare list.
Looks like the changes of the following PR #25380, have been overriding some styles.

Hopefully the test from this PR will avoid happening this again.

While running the test, without fixing the issue, we get the following result:

element click intercepted: Element <a data-bind=“attr: {href: product_url}, html: name” class=“product-item-link” href=“http://docker.enterprise.loc:8006/simpleproduct5e7c60f6959cc2.html”>...</a> is not clickable at point (141, 496). Other element would receive the click: <a href=“#” data-bind=“attr: {‘data-post’: remove_url}” title=“Remove This Item”

Related Pull Requests

Fixed Issues (if relevant)

  1. fixes Unable to open the product from sidebar's Compare Products block #21101: Unable to open the product from sidebar's Compare Products block

Manual testing scenarios (*)

  1. Add a product to your Compare Products list
  2. Check the sidebar for new added product for comparing
  3. Click on the Product's name

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Mar 26, 2020

Hi @eduard13. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Area: Design/Frontend Component: Wishlist Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Mar 26, 2020
@rogyar rogyar self-assigned this Mar 26, 2020
rogyar
rogyar requested changes Mar 26, 2020
View reviewed changes
...Wishlist/Test/Mftf/ActionGroup/StorefrontClickOnProductFromSidebarCompareListActionGroup.xml Outdated
*/
-->

<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend moving this action group to the Catalog module. Clicking on a product from the sidebar is not directly related to the wishlist. By moving it to the Catalog we will bring more chances that the newly introduced action group will be reused in the futures

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rogyar thank you for pointing this up. Looks like I got mixed up with the modules 🤦‍♂. I've moved the test and the new ActionGroup to the Catalog module.

@ghost ghost assigned eduard13 Mar 26, 2020
@ghost ghost removed the Progress: needs update label Mar 26, 2020
@eduard13 eduard13 mentioned this pull request Apr 5, 2020
Closed
4 tasks
@engcom-Echo engcom-Echo self-assigned this Apr 10, 2020
@VladimirZaets VladimirZaets added Priority: P3 May be fixed according to the position in the backlog. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Apr 10, 2020
@VladimirZaets VladimirZaets added this to the 2.4.1 milestone Apr 10, 2020
@slavvka slavvka modified the milestones: 2.4.1, 2.4.0 Apr 10, 2020
@VladimirZaets VladimirZaets added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label May 20, 2020
@engcom-Echo
Copy link
Contributor

@magento run all tests

@engcom-Alfa engcom-Alfa added QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Jun 10, 2020
@magento-engcom-team magento-engcom-team mentioned this pull request Jun 13, 2020
Closed
magento-engcom-team pushed a commit that referenced this pull request Jun 13, 2020
@slavvka
ENGCOM-7292: [Catalog] Unable to open the product from sidebar's Comp…
108d22f 
…are Products block #27451
@magento-engcom-team magento-engcom-team merged commit 0826289 into magento:2.4-develop Jun 13, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jun 13, 2020

Hi @eduard13, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar approved these changes

@mrtuvn mrtuvn mrtuvn approved these changes

Assignees

@rogyar rogyar

@eduard13 eduard13

@engcom-Alfa engcom-Alfa

@engcom-Echo engcom-Echo

Labels
Area: Design/Frontend Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Award: MFTF test coverage Component: Catalog Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
Pull Requests Dashboard
Archived in project
Milestone
2.4.1
Development

Successfully merging this pull request may close these issues.

Unable to open the product from sidebar's Compare Products block
8 participants
@eduard13 @magento-engcom-team @engcom-Alfa @engcom-Echo @mrtuvn @rogyar @VladimirZaets @slavvka